svc-admin01/snipe-it
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Allow lookup by serial number

Browse Source
This commit is contained in:
snipe
2026-05-07 16:01:46 +01:00
parent 0514901cbc
commit 2f3df9a085
2 changed files with 25 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Mcp/Tools/ShowAssetTool.php
+8 -5
View File
@@ -21,18 +21,19 @@ class ShowAssetTool extends Tool
{
$request->validate([
'asset_tag' => 'nullable|max:100',
'serial' => 'nullable|string|max:255',
'id' => 'nullable|integer',
]);
$with = ['status', 'model.category', 'model.manufacturer', 'location', 'defaultLoc', 'company', 'supplier', 'adminuser'];
$asset = null;
if ($request->filled('asset_tag')) {
$asset = Asset::where('asset_tag', $request->get('asset_tag'))
->with('status', 'assignedTo', 'model.category', 'model.manufacturer', 'location', 'defaultLoc', 'company', 'supplier', 'adminuser')
->first();
$asset = Asset::where('asset_tag', $request->get('asset_tag'))->with($with)->first();
} elseif ($request->filled('serial')) {
$asset = Asset::where('serial', $request->get('serial'))->with($with)->first();
} elseif ($request->filled('id')) {
$asset = Asset::with('status', 'assignedTo', 'model.category', 'model.manufacturer', 'location', 'defaultLoc', 'company', 'supplier', 'adminuser')
->find($request->get('id'));
$asset = Asset::with($with)->find($request->get('id'));
}
if (! $asset) {
@@ -84,6 +85,8 @@ class ShowAssetTool extends Tool
return [
'asset_tag' => $schema->string()
->description('The asset tag of the asset to look up'),
'serial' => $schema->string()
->description('The serial number of the asset to look up'),
'id' => $schema->number()
->description('The numeric ID of the asset to look up'),
];
tests/Feature/Mcp/ShowAssetToolTest.php
+17
View File
@@ -41,6 +41,23 @@ class ShowAssetToolTest extends TestCase
$this->assertEquals($asset->id, $content['id']);
}
public function test_finds_asset_by_serial()
{
$asset = Asset::factory()->create(['serial' => 'SN-FIND-001']);
$content = $this->handle(['serial' => 'SN-FIND-001'])->getStructuredContent();
$this->assertEquals('SN-FIND-001', $content['serial']);
$this->assertEquals($asset->id, $content['id']);
}
public function test_returns_error_when_serial_not_found()
{
$response = $this->handle(['serial' => 'DOES-NOT-EXIST']);
$this->assertTrue($response->responses()->first()->isError());
}
public function test_finds_asset_by_numeric_id()
{
$asset = Asset::factory()->create();